expose additional context when rendering #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikmueller
force-pushed
the
feature/additional-context
branch
from
81fe472 to
eace0db
Compare
erikmueller
force-pushed
the
feature/additional-context
branch
from
eace0db to
7db47dd
Compare
|
@mjackson any thoughts? |
|
Hey @erikmueller, sorry for the long silence here. I like this solution! Also, thanks for the tests! 😅 I'll merge and release in the next patch release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by http://blog.overstuffedgorilla.com/render-react-with-phoenix/ my use case was playing around with rendering react-router v4 inside an elixir application.
I had the problem of not being able to pass
contextthat is set during route matching in the react-router (and maybe populated with a response status) back to theplug.Router(to set the statusCode).I solved this with setting a
contextobject on the component itself and passing that back to the caller (theplug.Routerin that case). This may not be the most elegant solution but the only that came to my mind. Maybe s/o has something more awesome up their sleeves ;)Basically works like described in the
contextComponentand sInce I was too afraid to break sth I wrote some tests ^^